Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical inconsistency remains because removing ne from the shared species list leaves L1B converting it differently from the other species, and the related product documentation is also stale.
2 open issues
What changed in this PR
This pull request begins removing neon (ne) from the CoDICE Lo species inventory used for product generation.
Changes:
- Removes
nefromLO_SW_SPECIES_VARIABLE_NAMES. - Prepares L1A processing for the planned SCI-LUT update.
- Requires coordinated updates to L1B conversion, L2 species handling, and documentation.
This pull request requires changes.
| File | Review findings |
|---|---|
imap_processing/codice/constants.py |
Removing ne also affects L1B conversion while the SCI-LUT still emits it, causing inconsistent processing. The species inventory documentation is stale, and the L2 species list and related tests/configuration must be updated when neon removal is completed. |
Review effort: Lite
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The implementation can silently drop requested LUT-driven species by replacing the SCI-LUT union with a fixed list, while documentation and tests also leave the Ne-removal contract insufficiently verified.
5 open issues
2 resolved since last review
Review effort: Lite
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
partially closes #3455
Overview
The CoDICE team would like to remove all neon data from the CDFs. This PR removes 'ne' from the global variable list.
The next step is to remove "ne" from the desired species list in the sci_lut.
File changes